project-survey-bench-press #455
Conversation
fixing the button height
Page one container margin top 60 --> 40px
| --> | ||
| <title>Technigo React App</title> | ||
| <meta property="og:title" content="Big Dada's Gym"> | ||
| <meta property="og:description" content="We do the Math - You lift"> |
There was a problem hiding this comment.
Great job with the og-tags here Peki!
| return ( | ||
| <div> | ||
| Find me in src/app.js! | ||
| <div className="gym_app_container"> |
There was a problem hiding this comment.
Nice structure! It's easy to follow what happens in the different steps.
| @@ -0,0 +1,50 @@ | |||
| import React from 'react'; | |||
|
|
|||
There was a problem hiding this comment.
This is impressive Peki! Its easy to follow what happens with the 3 props in the 4 calculations. Even thou my math / workout skills aren't there I understand the results part :)
| {step < 4 && ( | ||
| <div className="button_container"> | ||
| {/* <p>Current step: {step}</p> */} | ||
| <button className="button-next" type="button" onClick={handleStepIncrease}>Next</button> |
There was a problem hiding this comment.
Here I think you could insert a conditional in the button that says something like: ? step === 4 : ' Submit' then the button text change to submit. But maybe this is a design dicision.
There was a problem hiding this comment.
Hello Peki!
First of all, great work with this project. It was uplifting seeing someone making something else then a regular question survey. Here the user actually gets useful information right away :).
Review:
The page showes up properly and do not crash or act strange in any situation that I could see. The requirements was to have at least 3 questions, use radiobuttons, dropdowns, and a submitbutton and you have that (I left a thought about the submit button in the code).
The code is well-structured and easy to follow what happens in the steps.
Nice and inspiring work!
No description provided.